Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of function that samples U3 phases from Haar distribution #1057

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Implementation of function that samples U3 phases from Haar distribution #1057

merged 13 commits into from
Nov 6, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 24, 2023 •
edited
Loading

This should be merged before #1056

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 24, 2023
@renatomello renatomello added this to the Qibo 0.2.2 milestone Oct 24, 2023
@renatomello renatomello self-assigned this Oct 24, 2023
@renatomello renatomello changed the title Uniform distribution for U3 Implementation of function that samples U3 phases from Haar distribution Oct 24, 2023
@renatomello renatomello mentioned this pull request Oct 24, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/qibo/quantum_info/random_ensembles.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

AlejandroSopena
AlejandroSopena reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@AlejandroSopena AlejandroSopena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello. Tests are not passing with cupy and cuQuantum. Wiith the changes below, it works locally for me:

src/qibo/quantum_info/random_ensembles.py Show resolved Hide resolved
tests/test_quantum_info_random.py Show resolved Hide resolved
@scarrazza scarrazza modified the milestones: Qibo 0.2.2, Qibo 0.2.3 Nov 2, 2023
@renatomello renatomello merged commit d279895 into master Nov 6, 2023
26 checks passed
@renatomello renatomello deleted the uniform_distribution branch November 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simone-Bordoni Simone-Bordoni Simone-Bordoni approved these changes

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

@stavros11 stavros11 Awaiting requested review from stavros11

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi Awaiting requested review from BrunoLiegiBastonLiegi

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@renatomello @AlejandroSopena @Simone-Bordoni @scarrazza