Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of qibo.models.encodings and implementation of unary_encoder #1059

Merged
merged 16 commits into from
Nov 1, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 26, 2023

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 26, 2023
@renatomello renatomello added this to the Qibo 0.2.2 milestone Oct 26, 2023
@renatomello renatomello self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/qibo/models/__init__.py 100.00% <100.00%> (ø)
src/qibo/models/encodings.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@renatomello renatomello marked this pull request as draft October 26, 2023 07:15
@renatomello renatomello marked this pull request as ready for review October 30, 2023 05:23
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it is fine for me.
Just a question, I noticed the notation is slightly different from the paper you cite in the docstrings. Did you apply these modifications in order to correctly deploy the data loader?
It perfectly works btw, so it sounds good to me.

@renatomello
Copy link
Contributor Author

Thank you, it is fine for me. Just a question, I noticed the notation is slightly different from the paper you cite in the docstrings. Did you apply these modifications in order to correctly deploy the data loader? It perfectly works btw, so it sounds good to me.

I don't know which part exactly you're referring to, but it's probably just personal preference.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, looks good to merge as it is. The only thing that is slightly weird is that this is exposed as a model, but the name follows different convention than other models. Some users may expect from qibo.models import UnaryEncoder. I get that you are following the function naming convention so it should be fine to keep as it is.

src/qibo/models/encodings.py Outdated Show resolved Hide resolved
src/qibo/models/encodings.py Outdated Show resolved Hide resolved
src/qibo/models/encodings.py Show resolved Hide resolved
src/qibo/models/encodings.py Show resolved Hide resolved
@renatomello renatomello merged commit 8940245 into master Nov 1, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants