-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decomposition for gates.FSWAP
#1093
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 8862 8860 -2
=========================================
- Hits 8862 8860 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello. This is fine with me, just wanted to mention that now that we have the transpiler in qibo, we should consider moving the Gate.decompose
method to the Unroller
interface. The main idea behind this was that we can have different Unroller
s for different applications. For example the FSWAP
may be decomposed to a set of GPI2
and CZ
for the hardware, but a different decomposition for some other application (if that makes sense and is useful).
That is of course if you and @BrunoLiegiBastonLiegi agree, but it is quite clear that the decompose
does the same thing with the Unroller
and I would rather focus on improving one approach than trying to maintain two competing ones. If you have suggestions to improve the transpiler these are also welcome.
Yeah I agree we should concentrate decompositions on the transpiler. This one is being done so @BrunoLiegiBastonLiegi can move forward with the Clifford simulator in #1076 and also it can serve as a benchmark for any unroller. |
Checklist: