-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create gates.CY
#1103
Create gates.CY
#1103
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello. Looks good to me, there is only an issue with tests. Using this and the corresponding branch for qibojit, the following test fails for me
tests/test_gates_density_matrix.py::test_controlled_by_one_qubit_gates[qibojit-numba-Y]
I have not checked what is wrong though. This is on CPU, I did not run on GPU yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for me it is ok, just fix the issue with the tests
for more information, see https://pre-commit.ci
@stavros11 @Simone-Bordoni I pushed the fix to qiboteam/qibojit#158 and one can test locally that all tests are passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello, it works for me now. For the CI, you probably need to run poetry lock
because you changed the pyproject, however I don't think this is needed as we will revert back to qibojit-main before merging.
I don't remember what we usually do in this situation, but most likely we need to release qibo 0.2.3, bump the dependency on qibojit's pyproject and run poetry lock
there.
I reverted back the change |
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
@renatomello does the windows failure is expected (due to the missing qibojit release)? |
Yes |
Thanks, I will merge this PR as the last one before release. |
This closes #1099 and needs qiboteam/qibojit#158 for
numba
tests to passChecklist: