Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError when Circuit.unitary and Circuit.invert are called and circuit contains noise channels #1111

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Nov 29, 2023

This closes #932 and #941

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Nov 29, 2023
@renatomello renatomello added this to the Qibo 0.2.3 milestone Nov 29, 2023
@renatomello renatomello self-assigned this Nov 29, 2023
@renatomello renatomello changed the title Raises NotImplementedError when Circuit.unitary is called and circuit has noise channels Raises NotImplementedError when Circuit.unitary and Circuit.invert are called and circuit contains noise channels Nov 29, 2023
@renatomello renatomello linked an issue Nov 29, 2023 that may be closed by this pull request
@renatomello renatomello changed the title Raises NotImplementedError when Circuit.unitary and Circuit.invert are called and circuit contains noise channels NotImplementedError when Circuit.unitary and Circuit.invert are called and circuit contains noise channels Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d0c55d) 100.00% compared to head (d20f6d4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9014      9018    +4     
=========================================
+ Hits          9014      9018    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello, looks good to me.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@renatomello renatomello merged commit 388ac58 into master Dec 1, 2023
21 checks passed
@renatomello renatomello deleted the circuit_unitaty branch December 1, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants