Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that randomly crashes for tensorflow #1112

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix test that randomly crashes for tensorflow #1112

merged 2 commits into from
Dec 1, 2023

Conversation

renatomello
Copy link
Contributor

This was first spotted by @BrunoLiegiBastonLiegi

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Nov 30, 2023
@renatomello renatomello added this to the Qibo 0.2.3 milestone Nov 30, 2023
@renatomello renatomello self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d0c55d) 100.00% compared to head (10b0bc0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1112   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9014      9014           
=========================================
  Hits          9014      9014           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza self-requested a review December 1, 2023 11:46
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello.

@scarrazza scarrazza merged commit 733f30a into master Dec 1, 2023
21 checks passed
@scarrazza scarrazza deleted the fix_test branch December 4, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants