Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in quantum_info.random_clifford #1114

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Fix bug in quantum_info.random_clifford #1114

merged 4 commits into from
Dec 1, 2023

Conversation

renatomello
Copy link
Contributor

The quantum_info.random_clifford function was breaking for nqubits >= 30 due to trying to create numbers bigger than the max of np.int64. This fixes it.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Dec 1, 2023
@renatomello renatomello added this to the Qibo 0.2.3 milestone Dec 1, 2023
@renatomello renatomello self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (388ac58) 100.00% compared to head (856691b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9022      9024    +2     
=========================================
+ Hits          9022      9024    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza merged commit aa1f039 into master Dec 1, 2023
21 checks passed
@renatomello renatomello deleted the random_clifford branch December 2, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants