Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes to make Clifford simulator GPU compatible #1124

Closed
wants to merge 6 commits into from

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Dec 6, 2023

This is necessary for #1076

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Dec 6, 2023
@renatomello renatomello added this to the Qibo 0.2.4 milestone Dec 6, 2023
@renatomello renatomello self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eea1e76) 100.00% compared to head (c6256ee) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9058      9056    -2     
=========================================
- Hits          9058      9056    -2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello requested a review from stavros11 December 7, 2023 05:20
@renatomello renatomello changed the title Fix GPU casting of array of samples in MeasurementResult.samples Miscellaneous fixes on qibo to make Clifford simulator GPU compatible Dec 7, 2023
@renatomello renatomello changed the title Miscellaneous fixes on qibo to make Clifford simulator GPU compatible Miscellaneous fixes to make Clifford simulator GPU compatible Dec 7, 2023
@renatomello renatomello marked this pull request as draft December 7, 2023 09:01
@renatomello
Copy link
Contributor Author

This is not necessary anymore since I was able to make the fixes solely in #1076. Therefore, I'm closing this PR.

@renatomello renatomello closed this Dec 8, 2023
@renatomello renatomello deleted the measurement_cast branch December 8, 2023 10:24
@renatomello renatomello removed this from the Qibo 0.2.4 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants