Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving energy fluctuation to Hamiltonian #1131

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Moving energy fluctuation to Hamiltonian #1131

merged 10 commits into from
Dec 14, 2023

Conversation

MatteoRobbiati
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati commented Dec 11, 2023 •
edited by renatomello
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2c815a) 100.00% compared to head (93e6236) 100.00%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9080      9078    -2     
=========================================
- Hits          9080      9078    -2
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrea-pasquale
andrea-pasquale approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MatteoRobbiati.
LGTM, just a small suggestion.

src/qibo/hamiltonians/hamiltonians.py Show resolved Hide resolved
@MatteoRobbiati MatteoRobbiati added this to the Qibo 0.2.4 milestone Dec 13, 2023
Edoardo-Pedicillo
Edoardo-Pedicillo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MatteoRobbiati

@MatteoRobbiati MatteoRobbiati merged commit 3e2b7b4 into master Dec 14, 2023
21 checks passed
@renatomello renatomello deleted the ene_fluc branch December 14, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edoardo-Pedicillo Edoardo-Pedicillo Edoardo-Pedicillo approved these changes

@andrea-pasquale andrea-pasquale andrea-pasquale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Qibo 0.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MatteoRobbiati @andrea-pasquale @Edoardo-Pedicillo