Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comp_basis_encoder to models.encodings #1165

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jan 24, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51a0e92) 100.00% compared to head (ab8e039) 100.00%.

❗ Current head ab8e039 differs from pull request most recent head bfb3ae3. Consider uploading reports for the commit bfb3ae3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         9883      9906   +23     
=========================================
+ Hits          9883      9906   +23     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello marked this pull request as ready for review January 24, 2024 14:05
@renatomello renatomello requested review from Simone-Bordoni and removed request for BrunoLiegiBastonLiegi January 24, 2024 14:05
@@ -247,6 +247,12 @@ Data Encoders

We provide a family of algorithms that encode classical data into quantum circuits.

Computational Basis Encoder
"""""""""""""""""""""""""""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a couple of words about this and the other encoders we already have? I remember I was trying to use them some time ago but I had a hard time understanding how to use them. A small example of how to encode data into circuits might help.

@renatomello renatomello self-assigned this Jan 28, 2024
@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 28, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Jan 28, 2024
@MatteoRobbiati MatteoRobbiati marked this pull request as draft January 31, 2024 09:14
@renatomello renatomello marked this pull request as ready for review February 2, 2024 05:23
doc/source/api-reference/qibo.rst Outdated Show resolved Hide resolved
@renatomello renatomello added this pull request to the merge queue Feb 2, 2024
Merged via the queue into master with commit 7585775 Feb 2, 2024
18 of 19 checks passed
@renatomello renatomello deleted the basis_encoding branch February 2, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants