Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split quantum_info.metrics into quantum_info.metric, quantum_info.entanglement, and quantum_info.entropies #1172

Merged
merged 76 commits into from
Feb 7, 2024
Merged

Split quantum_info.metrics into quantum_info.metric, quantum_info.entanglement, and quantum_info.entropies #1172

merged 76 commits into from
Feb 7, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jan 28, 2024 •
edited
Loading

This closes #1170

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Jan 28, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Jan 28, 2024
@renatomello renatomello self-assigned this Jan 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bfd6ec) 100.00% compared to head (786fce0) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #1172    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           69        71     +2     
  Lines        10107     10308   +201     
==========================================
+ Hits         10107     10308   +201
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlejandroSopena AlejandroSopena self-requested a review February 3, 2024 12:08
AlejandroSopena
AlejandroSopena reviewed Feb 3, 2024
View reviewed changes
Copy link
Contributor

@AlejandroSopena AlejandroSopena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Just one more thing:

doc/source/api-reference/qibo.rst Outdated Show resolved Hide resolved
AlejandroSopena
AlejandroSopena reviewed Feb 3, 2024
View reviewed changes
src/qibo/quantum_info/entropies.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entropies.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a18089b) 99.96% compared to head (785d532) 100.00%.
Report is 56 commits behind head on master.

❗ Current head 785d532 differs from pull request most recent head 7d35585. Consider uploading reports for the commit 7d35585 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #1172      +/-   ##
===========================================
+ Coverage   99.96%   100.00%   +0.03%     
===========================================
  Files          68        70       +2     
  Lines       10220     10409     +189     
===========================================
+ Hits        10216     10409     +193     
+ Misses          4         0       -4
Flag Coverage Δ
unittests 100.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi reviewed Feb 7, 2024
View reviewed changes
src/qibo/quantum_info/entanglement.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entanglement.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entropies.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entropies.py Show resolved Hide resolved
@renatomello renatomello added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit 3a2e434 Feb 7, 2024
19 checks passed
@renatomello renatomello deleted the entanglement_entropy branch February 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

Assignees

@renatomello renatomello

Labels
enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Milestone
Qibo 0.2.5
Development

Successfully merging this pull request may close these issues.

Split quantum_info.metrics into quantum_info.metric, quantum_info.entanglement, and quantum_info.entropies
4 participants
@renatomello @codecov-commenter @AlejandroSopena @BrunoLiegiBastonLiegi