-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phase_encoder
to models.encodings
and improve documentation of unary encoder(s)
#1190
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 69 69
Lines 10107 10124 +17
===========================================
+ Hits 10107 10123 +16
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this feature, it may be very useful for QML applications. (just fix coverage before merging)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 68
Lines 10186 10203 +17
=========================================
+ Hits 10186 10203 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
phase_encoder
to models.encodings
phase_encoder
to models.encodings
and improve documentation of unary encoder(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is very helpful indeed! I would just make the figures a tad smaller if possible.
Checklist: