Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phase_encoder to models.encodings and improve documentation of unary encoder(s) #1190

Merged
merged 13 commits into from
Feb 7, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Feb 5, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 5, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Feb 5, 2024
@renatomello renatomello self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2bfd6ec) 100.00% compared to head (2e91818) 99.99%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/qibo/models/encodings.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1190      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files           69       69              
  Lines        10107    10124      +17     
===========================================
+ Hits         10107    10123      +16     
- Misses           0        1       +1     
Flag Coverage Δ
unittests 99.99% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Simone-Bordoni Simone-Bordoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this feature, it may be very useful for QML applications. (just fix coverage before merging)

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bf0c4d) 100.00% compared to head (5dee64b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines        10186     10203   +17     
=========================================
+ Hits         10186     10203   +17     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Add phase_encoder to models.encodings Add phase_encoder to models.encodings and improve documentation of unary encoder(s) Feb 6, 2024
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very helpful indeed! I would just make the figures a tad smaller if possible.

@renatomello renatomello added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit 5eb7367 Feb 7, 2024
18 of 19 checks passed
@renatomello renatomello deleted the phase_encoding branch February 7, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants