-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SiSWAPDG
gate
#1191
Add SiSWAPDG
gate
#1191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 10170 10186 +16
=========================================
+ Hits 10170 10186 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would add the SiSWAPDG
gate to the documentation (doc.source...
).
I would also take the opportunity to fix the rendering of LaTeX in the SiSWAP
(one more brace than necessary).
Thanks for the docstring tip. I didn't add the gate to the API ref because no other "dagger" gate is there. |
I see, thanks. |
Checklist: