Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiSWAPDG gate #1191

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Add SiSWAPDG gate #1191

merged 4 commits into from
Feb 6, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Feb 5, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the enhancement New feature or request label Feb 5, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Feb 5, 2024
@renatomello renatomello self-assigned this Feb 5, 2024
@Simone-Bordoni Simone-Bordoni self-requested a review February 5, 2024 11:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (330f1bb) 100.00% compared to head (9c197dd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines        10170     10186   +16     
=========================================
+ Hits         10170     10186   +16     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would add the SiSWAPDG gate to the documentation (doc.source...).
I would also take the opportunity to fix the rendering of LaTeX in the SiSWAP (one more brace than necessary).

@renatomello
Copy link
Contributor Author

Thanks! I would add the SiSWAPDG gate to the documentation (doc.source...). I would also take the opportunity to fix the rendering of LaTeX in the SiSWAP (one more brace than necessary).

Thanks for the docstring tip. I didn't add the gate to the API ref because no other "dagger" gate is there.

@MatteoRobbiati
Copy link
Contributor

Thanks for the docstring tip. I didn't add the gate to the API ref because no other "dagger" gate is there.

I see, thanks.

@MatteoRobbiati MatteoRobbiati self-requested a review February 6, 2024 14:24
@renatomello renatomello added this pull request to the merge queue Feb 6, 2024
Merged via the queue into master with commit 176d75c Feb 6, 2024
19 checks passed
@renatomello renatomello deleted the siswap branch February 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants