-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytorch
backend
#1202
pytorch
backend
#1202
Conversation
I need a bit of help to finish this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Simone-Bordoni for this. Could you please include pytorch in tests by updating this file and check coverage?
I converted this PR to draft just because it's gonna take a little bit to finish it |
I thought it would have been an easy thing but there are many parts of qibo that are not backend agnostic and struggle with pytorch. |
Ok, now it makes sense. sorry if i changed it again, i will not touch it anymore |
I have reverted the changes to the test with seed so now everything should pass. Thanks to @BrunoLiegiBastonLiegi I also managed to remove some more unuseful methods in the pytorch backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Simone-Bordoni, please address these last minor things and open an issue about adding support to gradients in the pytorch backend. Then we can merge this I guess.
Backend based on
pytorch
for optimised automatic differentiation.Checklist: