Calculation of Clifford.stabilizers and Clifford.destabilizers in parallel
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatomello
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 10443 10450 +7
=========================================
+ Hits 10443 10450 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlejandroSopena
approved these changes
Feb 9, 2024
| @@ -150,6 +152,8 @@ def stabilizers(self, symplectic: bool = False, return_array: bool = False): | |||
| return_array (bool, optional): To be used when ``symplectic = False``. | |||
| If ``True`` returns the stabilizers as ``ndarray``. | |||
| If ``False``, returns stabilizers as strings. Defaults to ``False``. | |||
| cores (int, optional): number of processes to be used to calculate all stabilizers. | |||
There was a problem hiding this comment.
I think I would rather call this ncpus or similar, which from my experience is a more commonly used name for this kind of things.
Comment on lines
+443
to
+444
| pool.close() | ||
| pool.join() |
There was a problem hiding this comment.
Do we need these two?
|
I'm closing this PR because we might go in a different direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: