-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QASM parser #1207
QASM parser #1207
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 73 +1
Lines 10516 10531 +15
=========================================
+ Hits 10516 10531 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is anywhere in the docs mentioned that |
I don't think it is. We could explicitly say that now we support 3.0, but the problem is that this is not completely true, as not all the functions introduced in 3.0 are supported yet. |
Then, we could say it is compatible with 3.0. |
for more information, see https://pre-commit.ci
PS: I think this could still be done. Also the mention of compatibility in the documentation. |
Co-authored-by: Renato Mello <[email protected]>
@BrunoLiegiBastonLiegi could you please fix conflicts so we can proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This implements a QASM parser based on https://github.com/openqasm/openqasm.
This closes #1151 and is related to #626 #791.
Checklist: