Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates IBMQNoiseModel #1227

Merged
merged 27 commits into from
Mar 1, 2024
Merged

Creates IBMQNoiseModel #1227

merged 27 commits into from
Mar 1, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Feb 27, 2024 •
edited
Loading

Closes #1214 .

New class IBMQNoiseModel inherits NoiseModel, but allows for the creating of a noise model involving ThermalRelaxationError, DepolarizingError, and ReadoutError.

Noise model initialisation is done using a dictionary of parameters.

This class is meant to replace CompositeNoiseModel defined in noise_model.py.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 27, 2024
@renatomello renatomello self-assigned this Feb 27, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Feb 27, 2024
@renatomello renatomello marked this pull request as ready for review February 27, 2024 10:27
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (31bbbb4) to head (3bcec1b).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        71    -1     
  Lines        10480     10389   -91     
=========================================
- Hits         10480     10389   -91
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello
Copy link
Contributor Author

@rahula06 @MatteoRobbiati @AlejandroSopena this is ready for review

@rahula06
Copy link
Contributor

rahula06 commented Feb 29, 2024 •
edited
Loading

Thanks a lot for your work on this, @renatomello :)

I've been using this branch in our application, replacing the CompositeNoiseModel with the IBMQNoiseModel and it seems to work well. I'll do the same with the latest commits as well, just in case

@renatomello
Copy link
Contributor Author

renatomello commented Feb 29, 2024 •
edited
Loading

Thanks a lot for your work on this, @renatomello :)

I've been using this branch in our application, replacing the CompositeNoiseModel with the IBMQNoiseModel and it seems to work well. I'll do the same with the latest commits as well, just in case

May I ask you to review this PR between today and tomorrow? I'd like your input since you're using the class in an application. And if we can merge this by tomorrow it's going to be in the next qibo release.

rahula06
rahula06 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@rahula06 rahula06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, there are no problems in application.

rahula06
rahula06 reviewed Mar 1, 2024
View reviewed changes
doc/source/api-reference/qibo.rst
In Qibo, it is possible to build a realistic noise model of a real quantum computer
by using the :meth:`qibo.noise.NoiseModel.composite()` method.
In Qibo, it is possible to build noisy circuits based on IBMQ's reported noise model of
for its quantum computer by using the :class:`qibo.noise.IBMQNoiseModel` class.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a typo here in "reported noise model of for its quantum computer".

@scarrazza
Copy link
Member

@renatomello can we conclude this later today for the next release?

@renatomello
Copy link
Contributor Author

renatomello commented Mar 1, 2024 via email

@scarrazza scarrazza self-requested a review March 1, 2024 11:38
scarrazza
scarrazza approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renatomello thanks, could you please fix the conflict and merge?

@scarrazza scarrazza added this pull request to the merge queue Mar 1, 2024
Merged via the queue into master with commit 1ae3aa1 Mar 1, 2024
21 checks passed
@scarrazza scarrazza deleted the composite_noise_model branch June 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahula06 rahula06 rahula06 approved these changes

@scarrazza scarrazza scarrazza approved these changes

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

@AlejandroSopena AlejandroSopena Awaiting requested review from AlejandroSopena

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.5
Development

Successfully merging this pull request may close these issues.

Remove noise_model.noisy_circuit and NoiseModel.composite
3 participants
@renatomello @rahula06 @scarrazza