-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for cupy
and cuquantum
backends
#1238
Conversation
cuquantum
backendcupy
and cuquantum
backends
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1238 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 72 72
Lines 10520 10528 +8
=======================================
+ Hits 10501 10509 +8
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello, I see that it is not completed yet, but it already seems a simplification.
As soon as you complete, I'll be glad to approve!
Some tests in |
@MatteoRobbiati the majority of DBI tests are failing on GPU. It seems that it is because |
If you are receiving the global backend from a fixture, as in here: Lines 57 to 59 in 31bbbb4
you could add some cleanup code after the yield .
|
I also saw the same behavior some time ago, very weird.
You are right, given that we don't tests on GPU with the CI sometimes we forget. I can also have a look if you want @MatteoRobbiati. |
It's better to move forward with this PR only after #1202 is merged |
for more information, see https://pre-commit.ci
All tests should be passing on GPUs now. Someone else should test locally too. Thanks @andrea-pasquale for making DBI tests faster and GPU compatible. |
Checklist: