Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep copy of gates.M in Circuit.copy() #1250

Merged
merged 11 commits into from
Mar 14, 2024
Merged

Fix deep copy of gates.M in Circuit.copy() #1250

merged 11 commits into from
Mar 14, 2024

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Mar 6, 2024

Bugfix to #1249 .

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added this to the Qibo 0.2.6 milestone Mar 6, 2024
@renatomello renatomello added the bug Something isn't working label Mar 6, 2024
@renatomello renatomello self-requested a review March 6, 2024 10:02
@renatomello renatomello linked an issue Mar 6, 2024 that may be closed by this pull request
@renatomello renatomello changed the title Circuit.copy() fix Fix deep copy of gates.M in Circuit.copy() Mar 7, 2024
@renatomello
Copy link
Contributor

It's best to fix the tests here only after #1202 is merged.

@scarrazza scarrazza modified the milestones: Qibo 0.2.6, Qibo 0.2.7 Mar 13, 2024
@renatomello
Copy link
Contributor

@BrunoLiegiBastonLiegi
Copy link
Contributor Author

BrunoLiegiBastonLiegi commented Mar 14, 2024

@BrunoLiegiBastonLiegi unrelated: do you know why this is failing? https://github.com/qiboteam/qibo/actions/runs/8281358719/job/22660149672

I would say that the lock needs to be regenerated, after the PytorchBackend merge you need torch installed but if you only have the pyproject.toml updated it's not gonna install torch I believe, but I might be wrong.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (3474d5e) to head (8208831).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
- Coverage   99.95%   99.94%   -0.01%     
==========================================
  Files          73       73              
  Lines       10636    10638       +2     
==========================================
+ Hits        10631    10632       +1     
- Misses          5        6       +1     
Flag Coverage Δ
unittests 99.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello marked this pull request as ready for review March 14, 2024 14:39
@renatomello renatomello added this pull request to the merge queue Mar 14, 2024
Merged via the queue into master with commit 66252b6 Mar 14, 2024
21 checks passed
@renatomello renatomello deleted the copy_M branch March 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit.copy() doesn't copy the MeasurementResult object correctly
4 participants