-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving documentation of models.encodings.entangling_layer
#1273
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 73 73
Lines 10690 10690
=======================================
Hits 10674 10674
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello!
I think it would be better to standardize a bit more the images in the section. To do this, we should keep the width in the usual range of 400px-800px
, and regulate the height. For helping in this, I opened #1278, where the scale
tag is removed and the images widths and heights are rescaled to fit the aforementioned range.
The #1278 is pointing here, thus I would suggest to check that one and then proceed with this PR.
A couple of suggestions follow.
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Standardize images in encoding documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Checklist: