Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gates.GeneralizedRBS gate #1373

Merged
merged 45 commits into from
Aug 15, 2024
Merged

Add gates.GeneralizedRBS gate #1373

merged 45 commits into from
Aug 15, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jun 26, 2024

This needs qiboteam/qibojit#183

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 26, 2024
@renatomello renatomello added this to the Qibo 0.2.10 milestone Jun 26, 2024
@renatomello renatomello self-assigned this Jun 26, 2024
@renatomello renatomello marked this pull request as draft June 26, 2024 09:47
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (37e1010) to head (3e83876).
Report is 46 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          78       78           
  Lines       11236    11297   +61     
=======================================
+ Hits        11230    11291   +61     
  Misses          6        6           
Flag Coverage Δ
unittests 99.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/qibo/gates/gates.py Outdated Show resolved Hide resolved
src/qibo/backends/npmatrices.py Show resolved Hide resolved
src/qibo/backends/npmatrices.py Outdated Show resolved Hide resolved
@renatomello renatomello requested a review from alecandido June 26, 2024 11:54
@renatomello renatomello marked this pull request as ready for review June 26, 2024 11:54
@scarrazza scarrazza modified the milestones: Qibo 0.2.10, Qibo 0.2.11 Jul 24, 2024
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

src/qibo/transpiler/decompositions.py Show resolved Hide resolved
@renatomello
Copy link
Contributor Author

renatomello commented Aug 14, 2024

@scarrazza @MatteoRobbiati the PR in qibojit needs to be merged before this one

@scarrazza scarrazza merged commit 4f57f37 into master Aug 15, 2024
27 checks passed
@renatomello renatomello deleted the grbs branch August 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants