Add Minimum Vertex Cover in example #574
Conversation
|
@ianmalcolm thanks for this PR. We had discussed about this implementation today, and we would like to check with you if the |
Yes, it is possible. I will change the function to have a qibo Hamiltonian object. |
| @@ -0,0 +1,201 @@ | |||
| ```python | |||
There was a problem hiding this comment.
@ianmalcolm thanks for this. I think we can keep this README and remove the jupyter notebook.
There was a problem hiding this comment.
demo.ipynb is removed in 604d971
| @@ -0,0 +1,113 @@ | |||
| from typing import Dict, List, Tuple, Union, Any, Optional, Generator, Iterator, Hashable | |||
|
|
|||
| def binary2spin(linear: Dict[int, float], | |||
There was a problem hiding this comment.
@ianmalcolm following our discussion today, let me suggest to remove binary2spin and keep just a single function graph2hamiltonian(graph, penalty).
There was a problem hiding this comment.
There was a problem hiding this comment.
@ianmalcolm, we have to rebase this branch from master.
Could you please open another PR from master directly from this repository (no fork)?
Add utils to convert between binary and spin models Ensure all decision variables appear in the linear terms. In rare cases, a variable could be ignored if it has zero bias and iteractions and would be missing in final solutions and causes problems. Add a negative sign to hamiltonian Add the usage of converting mvc problem to hamiltonian and an example of adiabatic time evolution. Add tests Add test entry for mvc Add hamiltonian_mvc, which directly creates a hamiltonian from a networkx graph Remove duplicated documentaiton Add test on hamiltonian_mvc Revert "Remove duplicated documentaiton" This reverts commit 1decc38. Remove duplicated documentation
Hi @scarrazza I just rebase my |
|
@ianmalcolm thanks, yes please open another PR but using the qibo repository as baseline instead of your fork (i.e. clone the qibo repository and move your branch changes to a new PR. |
Hi @scarrazza,
May I have your comments on this pull request, please?
Many thanks!