Skip to content

Commit

Permalink
docs
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacfomg committed Nov 2, 2023
1 parent 9dbeeca commit 52cbc4a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class CouplerSpectroscopyParametersQubit(CouplerSpectroscopyParameters):
drive_duration: Optional[int] = 2000
"""Drive pulse duration to excite the qubit before the measurament"""
"""Drive pulse duration to excite the qubit before the measurement"""


def _acquisition(
Expand All @@ -32,11 +32,9 @@ def _acquisition(
on the flux coupler pulse amplitude requiered to enable 2q interactions.
"""
"""
We may want to measure both qubits on the pair,
that will require a different acquisition, for now I suggest to only measure one and reduce possible crosstalk.
Zurich crashes on several pairs due to the single oscillator issue.
"""

# TODO: Do we want to measure both qubits on the pair ?
# Different acquisition, for now only measure one and reduce possible crosstalk.

# create a sequence of pulses for the experiment:
# Coupler pulse while Drive pulse - MZ
Expand Down Expand Up @@ -80,7 +78,7 @@ def _acquisition(
-params.bias_width / 2, params.bias_width / 2, params.bias_step
)

"""This sweeper is implemented in the flux pulse amplitude and we need it to be that way. """
# This sweeper is implemented in the flux pulse amplitude and we need it to be that way.
sweeper_bias = Sweeper(
Parameter.bias,
delta_bias_range,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

class CouplerSpectroscopyParametersResonator(CouplerSpectroscopyParameters):
readout_delay: Optional[int] = 1000
"""Readout delay before the measurament is done to let the flux coupler pulse act"""
"""Readout delay before the measurement is done to let the flux coupler pulse act"""


def _acquisition(
Expand All @@ -37,11 +37,8 @@ def _acquisition(
"""

"""
We may want to measure both qubits on the pair,
that will require a different acquisition, for now I suggest to only measure one and reduce possible crosstalk.
Zurich crashes on several pairs due to the single oscillator issue.
"""
# TODO: Do we want to measure both qubits on the pair ?
# Different acquisition, for now only measure one and reduce possible crosstalk.

# create a sequence of pulses for the experiment:
# Coupler pulse while MZ
Expand All @@ -59,7 +56,6 @@ def _acquisition(
coupler = platform.pairs[tuple(sorted(ordered_pair))].coupler
couplers.append(coupler)

# TODO: Does it need time or can it start at 0 ???
# TODO: May measure both qubits on the pair
ro_pulses[qubit] = platform.create_qubit_readout_pulse(
qubit, start=params.readout_delay
Expand All @@ -86,7 +82,7 @@ def _acquisition(
-params.bias_width / 2, params.bias_width / 2, params.bias_step
)

"""This sweeper is implemented in the flux pulse amplitude and we need it to be that way. """
# This sweeper is implemented in the flux pulse amplitude and we need it to be that way.
sweeper_bias = Sweeper(
Parameter.bias,
delta_bias_range,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ def flux_dependence_plot(data, fit, qubit):
)
else:
subplot_titles = (
"MSR [V]_q" + str(qubit),
"Phase [rad]_q" + str(qubit),
"MSR [V] Qubit" + str(qubit),
"Phase [rad] Qubit" + str(qubit),
)

fig = make_subplots(
Expand Down
7 changes: 0 additions & 7 deletions src/qibocal/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,6 @@ def drive_12_amplitude(amplitude: float, platform: Platform, qubit: QubitId):
platform.qubits[qubit].native_gates.RX12.amplitude = float(amplitude)


# TODO: Proper update
def coupler_sweetspot(sweetspot: float, platform: Platform, qubit: QubitId):
platform.couplers[qubit].sweetspot = float(sweetspot)
if platform.couplers[qubit].flux is not None:
platform.couplers[qubit].flux.offset = sweetspot


def twpa_frequency(frequency: int, platform: Platform, qubit: QubitId):
platform.qubits[qubit].twpa.local_oscillator.frequency = int(frequency)

Expand Down

0 comments on commit 52cbc4a

Please sign in to comment.