Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RX90 calibration implementation #1044
RX90 calibration implementation #1044
Changes from 15 commits
14f80b4
ec4b7ad
9f63c69
33db217
32cceda
7661361
d03f383
d0c1228
e6a2395
144f468
c112748
f083434
f52765f
efcb55a
66f0b71
1f16f50
f8e9021
a08cf3c
0f9ec82
6111a46
973b318
3164fd8
393d039
1742dc1
30dd98c
f521abc
bf70bf6
349e312
07a62b8
1873ccb
ef2e21a
7deade0
222539d
62230c9
23ae111
4dbcc34
3427756
3c676ff
df453df
92e0d71
1f9d532
31db8b7
c579cbb
64e5352
3c4e0d9
04cf0f9
cf73084
f6bfcaf
454f5b5
47a22b5
96dd44e
07a4bcd
e8cea9a
4052755
12fedb5
b58e13a
32308e2
57904a1
3b6769d
29a1296
022240d
8b0995d
98bcf1d
17ba606
7b907ae
7660fde
2d8c8f7
1bac594
af82fec
228a02e
35c7178
8950008
b90f887
23ee280
01a4d1a
c5bb28f
f62bbc3
832d0e9
05c2886
478c864
837cc08
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and everywhere: I'd suggest adopting
rx90
as identifier, to be consistent with the parameter, since it will always contain exactly the same value. This will make more intuitive to understand the connection :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it everywhere. Also changed
pulse : bool
inrabi/utils.py
torx90: bool