Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qibo and qibolab dependencies #752

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Update qibo and qibolab dependencies #752

merged 7 commits into from
Mar 21, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Mar 13, 2024

I'm trying to upgrade both qibo and qibolab and I'm finding some issues along the way qiboteam/qibolab#833 qiboteam/qibo#1262

This PR should also address #751.

  • revert qibo and qibolab to stable releases

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added dependencies Pull requests that update a dependency file qibolab release required PR requires qibolab feature not available in the current poetry.lock qibo release required PR requires qibo feature not available in current poetry.lock labels Mar 13, 2024
@andrea-pasquale andrea-pasquale self-assigned this Mar 13, 2024
@Edoardo-Pedicillo
Copy link
Contributor

while this error be fixed in #597 @Jacfomg @Edoardo-Pedicillo?

Yes

@andrea-pasquale andrea-pasquale changed the base branch from main to fix-std-RB March 13, 2024 19:47
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.20%. Comparing base (c171ad9) to head (c3439ee).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   97.23%   97.20%   -0.03%     
==========================================
  Files         102      102              
  Lines        7297     7301       +4     
==========================================
+ Hits         7095     7097       +2     
- Misses        202      204       +2     
Flag Coverage Δ
unittests 97.20% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/auto/runcard.py 96.42% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

@andrea-pasquale andrea-pasquale marked this pull request as ready for review March 13, 2024 19:55
@andrea-pasquale andrea-pasquale added the do not merge Soft warning to avoid merging a PR for reason provided in the PR label Mar 13, 2024
@andrea-pasquale
Copy link
Contributor Author

  • revert qibo and qibolab to stable releases

I've added the do not merge tag because of this, the PR should still be ready to review.

pyproject.toml Outdated Show resolved Hide resolved
@andrea-pasquale andrea-pasquale removed the qibo release required PR requires qibo feature not available in current poetry.lock label Mar 20, 2024
@andrea-pasquale andrea-pasquale changed the base branch from fix-std-RB to main March 21, 2024 13:50
@andrea-pasquale andrea-pasquale changed the base branch from main to fix-std-RB March 21, 2024 14:04
@andrea-pasquale andrea-pasquale changed the base branch from fix-std-RB to main March 21, 2024 14:28
@andrea-pasquale andrea-pasquale changed the base branch from main to fix-std-RB March 21, 2024 14:31
@andrea-pasquale andrea-pasquale changed the base branch from fix-std-RB to main March 21, 2024 14:43
@andrea-pasquale andrea-pasquale removed do not merge Soft warning to avoid merging a PR for reason provided in the PR qibolab release required PR requires qibolab feature not available in the current poetry.lock labels Mar 21, 2024
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 2244726 Mar 21, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the upgrade_dep branch March 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants