Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis rotation circuit #35

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Basis rotation circuit #35

merged 7 commits into from
Oct 6, 2023

Conversation

chmwzc
Copy link
Contributor

@chmwzc chmwzc commented Aug 21, 2023

Google's basis rotation circuit ansatz. Should be OK, will un-draft it after I do a bit more testing and write up an example.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/qibochem/ansatz/basis_rotation.py 98.07% <98.07%> (ø)

📢 Thoughts on this report? Let us know!.

@chmwzc chmwzc force-pushed the dev/basis-rotation branch from ca5c309 to f4ba470 Compare August 29, 2023 06:17
@chmwzc chmwzc marked this pull request as ready for review September 6, 2023 02:57
Copy link
Contributor

@damarkian damarkian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pass codecov. Maybe some tests?

@chmwzc
Copy link
Contributor Author

chmwzc commented Oct 6, 2023

Yup, doing that now actually haha

@damarkian damarkian merged commit 40f0783 into main Oct 6, 2023
6 checks passed
@chmwzc chmwzc deleted the dev/basis-rotation branch October 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants