Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added examples to demonstrate various Bell inequalities #15

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Added examples to demonstrate various Bell inequalities #15

wants to merge 17 commits into from

Conversation

glpatcern
Copy link
Collaborator

Follow up of #14

This was linked to issues Oct 5, 2024
Add Bell inequalities notebook #11
Open
Add CHSH notebook #12
Open
@glpatcern
Copy link
Collaborator Author

glpatcern commented Oct 10, 2024 •
edited
Loading

@MatteoRobbiati the changes look good, except for the Bell-Wigner notebook where the radial plot has a non-optimal scaling compared to my version. If you want we can meet some time before you leave to have a look.

@glpatcern
Copy link
Collaborator Author

I have fixed the radial plots and made the plot parameters a bit more generic. This is now final for me, @MatteoRobbiati can you please review?

@glpatcern glpatcern marked this pull request as draft November 7, 2024 09:08
@glpatcern glpatcern marked this pull request as ready for review November 8, 2024 08:58
@MatteoRobbiati MatteoRobbiati self-requested a review November 12, 2024 13:37
@MatteoRobbiati
Copy link
Collaborator

I did my final modifications @glpatcern. Please have a look!

@glpatcern glpatcern marked this pull request as draft November 12, 2024 21:02
@glpatcern glpatcern force-pushed the bell branch 2 times, most recently from 2faad45 to b6e276a Compare November 13, 2024 13:11
@glpatcern glpatcern marked this pull request as ready for review November 13, 2024 13:15
@glpatcern
Copy link
Collaborator Author

I did my final modifications @glpatcern. Please have a look!

All good @MatteoRobbiati, I have moved as agreed the notebooks to a dedicated folder plus added a README, you can go ahead and do the same for the other lectures.

@MatteoRobbiati
Copy link
Collaborator

Thanks @glpatcern! I would rename the folder and the notebooks without spacing between words. I would use _ instead. A part from that LGTM! I would merge this and then I will re-arrange the other lectures in a second moment.

@glpatcern
Copy link
Collaborator Author

Agreed! Let me rename and then we merge once we submit the paper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

@scarrazza scarrazza Awaiting requested review from scarrazza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CHSH notebook Add Bell inequalities notebook
2 participants
@glpatcern @MatteoRobbiati