Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for tensor network benchmarking #43

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

liweintu
Copy link
Contributor

This PR addresses issue #41 . It is still work-in-progress (WIP), please do not merge it at this moment.

This WIP PR is created to enable us to iteratively address reviews from @alecandido , @stavros11 and @scarrazza . Also, it allows other teammates to contribute to its implementation because we don't have a specific TNet branch in this repo to contribute code to.

@alecandido alecandido marked this pull request as draft April 26, 2023 09:09
@alecandido
Copy link
Member

Since it is WIP I made it draft. In Qibo there is no official policy for use of draft PRs, but I believe that a set of sensible guidelines is the following:

  1. make a PR as soon as you start working on something (as you did), to make everyone aware of what you're doing
  2. keep it draft for as long as you don't have a candidate to merge
  3. when you undraft, add some reviewers (but if you need some help feel free to do it even before)

@liweintu
Copy link
Contributor Author

Since it is WIP I made it draft. In Qibo there is no official policy for use of draft PRs, but I believe that a set of sensible guidelines is the following:

  1. make a PR as soon as you start working on something (as you did), to make everyone aware of what you're doing
  2. keep it draft for as long as you don't have a candidate to merge
  3. when you undraft, add some reviewers (but if you need some help feel free to do it even before)

@alecandido Yup, this makes sense. And adding reviewers like yourself early is helpful so that we can receive early reviews to guide the designing of the code architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants