Bugfix to matrix unpacking for CliffordBackend
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoLiegiBastonLiegi
requested review from
renatomello and
AlejandroSopena
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 12 12
Lines 1115 1115
=======================================
Hits 1114 1114
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyproject.toml
Outdated
| @@ -22,7 +22,7 @@ classifiers = [ | |||
| [tool.poetry.dependencies] | |||
| python = "^3.9,<3.13" | |||
| numba = ">=0.59.0" | |||
| qibo = "^0.2.10" | |||
| qibo = { git = "https://github.com/qiboteam/qibo", branch = "clifford_unpack_fix" } | |||
There was a problem hiding this comment.
Remember to revert this and the changes to the poetry file
renatomello
approved these changes
Sep 20, 2024
|
This is failing because it needs qiboteam/qibo#1454. |
AlejandroSopena
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to be merged after qiboteam/qibo#1457.
GPU tests are passing.