Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ExecutionParameters in the public API #1047

Closed
alecandido opened this issue Sep 18, 2024 · 0 comments · Fixed by #1052
Closed

Replace ExecutionParameters in the public API #1047

alecandido opened this issue Sep 18, 2024 · 0 comments · Fixed by #1052
Milestone

Comments

@alecandido
Copy link
Member

I would expect the change to be pretty minimal: use kwargs instead of options in Platform.execute(sequences, sweepers=None, **kwargs) and do

options = ExecutionParameters(**kwargs)

right after. Also, remove ExecutionParameters from the public API and I guess some updates in the docs/README. If it's only that we could probably do in the short time we have, if it ends up being more complicated certainly no.

Whether it's sufficiently advantageous I am not sure. It should make Platform.execute slightly easier to use, particularly for users who are not interested in the whole content of ExecutionParameters (and only care about say nshots), but even this may be subjective.

Btw, I could also do that, if you agree.

Originally posted by @stavros11 in #1030 (comment)

We're attempting this for 0.2 - if not sufficiently stable, it will be moved directly to 0.3

@alecandido alecandido mentioned this issue Sep 18, 2024
1 task
@alecandido alecandido added this to the Qibolab 0.2.0 milestone Sep 18, 2024
@alecandido alecandido linked a pull request Sep 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant