Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make execution parameters private #1052

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Sep 19, 2024

Closes #1047

@alecandido alecandido added this to the Qibolab 0.2.0 milestone Sep 19, 2024
@alecandido alecandido linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (6fbf53f) to head (c0a2e42).
Report is 8 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #1052      +/-   ##
==========================================
- Coverage   52.10%   52.08%   -0.02%     
==========================================
  Files          63       63              
  Lines        2806     2803       -3     
==========================================
- Hits         1462     1460       -2     
+ Misses       1344     1343       -1     
Flag Coverage Δ
unittests 52.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido force-pushed the private-execution-parameters branch from 83138cf to 962bbe5 Compare September 19, 2024 16:44
@alecandido
Copy link
Member Author

@stavros11 whenever you can, also take a look at this.

If you like the result, we could keep it and include in the release.

@alecandido alecandido mentioned this pull request Sep 19, 2024
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido. It looks good and I believe we should have this in 0.2.

In c0a2e42 I updated some tests that were still using ExecutionParameters in platform.execute. Most were marked with qpu so are skipped and maybe we will even drop them at some point, but maybe still good to be consistent. Just found them by searching for ExecutionParameters.

@alecandido
Copy link
Member Author

Thanks @stavros11 for the update.

I actually paid little attention to the qpu tests in general, and we may need to reconsider a bit the strategy concerning them, even in light of #1039 and similar. But this is something we should definitely do in 0.2.1 (or following).

I'm merging :)

@alecandido alecandido merged commit 58d79ed into 0.2 Sep 19, 2024
28 checks passed
@alecandido alecandido deleted the private-execution-parameters branch September 19, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ExecutionParameters in the public API
2 participants