-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make execution parameters private #1052
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1052 +/- ##
==========================================
- Coverage 52.10% 52.08% -0.02%
==========================================
Files 63 63
Lines 2806 2803 -3
==========================================
- Hits 1462 1460 -2
+ Misses 1344 1343 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
83138cf
to
962bbe5
Compare
@stavros11 whenever you can, also take a look at this. If you like the result, we could keep it and include in the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alecandido. It looks good and I believe we should have this in 0.2.
In c0a2e42 I updated some tests that were still using ExecutionParameters
in platform.execute
. Most were marked with qpu
so are skipped and maybe we will even drop them at some point, but maybe still good to be consistent. Just found them by searching for ExecutionParameters
.
Thanks @stavros11 for the update. I actually paid little attention to the I'm merging :) |
Closes #1047