Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #1051

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Update README #1051

merged 5 commits into from
Sep 20, 2024

Conversation

stavros11
Copy link
Member

Close #1043. I also removed a log message from platform.connect because it would trigger very long output if the default dataclass (pydantic) representation is used for the instrument object (which has been overlooked mainly due to QM hiding the logger).

This should be ready, but maybe further changes will be needed if we do any last minute tweaks in the interface.

@stavros11 stavros11 added this to the Qibolab 0.2.0 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.32%. Comparing base (26df7f2) to head (b5f8db4).
Report is 31 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #1051      +/-   ##
==========================================
- Coverage   52.34%   52.32%   -0.02%     
==========================================
  Files          63       63              
  Lines        2820     2819       -1     
==========================================
- Hits         1476     1475       -1     
  Misses       1344     1344              
Flag Coverage Δ
unittests 52.32% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from public-api to 0.2 September 19, 2024 13:02
@alecandido alecandido linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flagged what I believe may require updates with the remaining PRs.

However, whenever everything else is merged, we can merge even this.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@scarrazza scarrazza self-requested a review September 20, 2024 08:43
@stavros11 stavros11 merged commit 486c6c7 into 0.2 Sep 20, 2024
28 checks passed
@stavros11 stavros11 deleted the readme branch September 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review README for 0.2
3 participants