-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #1051
Update README #1051
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1051 +/- ##
==========================================
- Coverage 52.34% 52.32% -0.02%
==========================================
Files 63 63
Lines 2820 2819 -1
==========================================
- Hits 1476 1475 -1
Misses 1344 1344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I flagged what I believe may require updates with the remaining PRs.
However, whenever everything else is merged, we can merge even this.
Close #1043. I also removed a
log
message fromplatform.connect
because it would trigger very long output if the default dataclass (pydantic) representation is used for the instrument object (which has been overlooked mainly due to QM hiding the logger).This should be ready, but maybe further changes will be needed if we do any last minute tweaks in the interface.