-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baking in QM driver #1005
Add baking in QM driver #1005
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1005 +/- ##
==========================================
- Coverage 42.88% 42.80% -0.09%
==========================================
Files 80 80
Lines 5624 5642 +18
==========================================
+ Hits 2412 2415 +3
- Misses 3212 3227 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is now fully implemented (excluding #1007 which I am not planning to do for 0.2) and tested on a few different occasions including rectangular pulses. |
@alecandido thanks for approving. Shall I merge this? There may be conflicts with #1001 but hopefully not much. |
I will take care of rebasing. Please, go ahead :) |
Essentially support playing and sweeping over durations with 1ns resolution (lifting the 4ns constraint). Also the related discussion in #979 should now be fixed. Here I am doing the "baking" (=padding with zeros) myself, instead of using the QM helpers, because this way it fits better with the rest of the driver.
Here is an example of the Rabi length with 1ns step: http://login.qrccluster.com:9000/EWxzJbXUSwmaT8_ES4pF0g==
This is ready for the most part. I just need to check how it behaves for rectangular pulses, but I need to write a script to do this.