Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baking in QM driver #1005

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Add baking in QM driver #1005

merged 9 commits into from
Aug 27, 2024

Conversation

stavros11
Copy link
Member

Essentially support playing and sweeping over durations with 1ns resolution (lifting the 4ns constraint). Also the related discussion in #979 should now be fixed. Here I am doing the "baking" (=padding with zeros) myself, instead of using the QM helpers, because this way it fits better with the rest of the driver.

Here is an example of the Rabi length with 1ns step: http://login.qrccluster.com:9000/EWxzJbXUSwmaT8_ES4pF0g==

This is ready for the most part. I just need to check how it behaves for rectangular pulses, but I need to write a script to do this.

@stavros11 stavros11 requested review from alecandido and removed request for alecandido August 25, 2024 11:25
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 30 lines in your changes missing coverage. Please review.

Project coverage is 42.80%. Comparing base (e7a8d18) to head (60580ce).
Report is 10 commits behind head on 0.2.

Files Patch % Lines
src/qibolab/instruments/qm/program/instructions.py 7.14% 13 Missing ⚠️
src/qibolab/instruments/qm/program/sweepers.py 14.28% 6 Missing ⚠️
src/qibolab/instruments/qm/config/pulses.py 16.66% 5 Missing ⚠️
src/qibolab/instruments/qm/config/config.py 0.00% 4 Missing ⚠️
src/qibolab/instruments/qm/controller.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #1005      +/-   ##
==========================================
- Coverage   42.88%   42.80%   -0.09%     
==========================================
  Files          80       80              
  Lines        5624     5642      +18     
==========================================
+ Hits         2412     2415       +3     
- Misses       3212     3227      +15     
Flag Coverage Δ
unittests 42.80% <11.76%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido added this to the Qibolab 0.2.0 milestone Aug 27, 2024
@stavros11 stavros11 marked this pull request as ready for review August 27, 2024 16:02
@stavros11
Copy link
Member Author

This is now fully implemented (excluding #1007 which I am not planning to do for 0.2) and tested on a few different occasions including rectangular pulses.

@stavros11 stavros11 requested a review from alecandido August 27, 2024 17:09
@stavros11
Copy link
Member Author

@alecandido thanks for approving. Shall I merge this? There may be conflicts with #1001 but hopefully not much.

@alecandido
Copy link
Member

@alecandido thanks for approving. Shall I merge this? There may be conflicts with #1001 but hopefully not much.

I will take care of rebasing. Please, go ahead :)

@stavros11 stavros11 merged commit d91498e into 0.2 Aug 27, 2024
27 of 28 checks passed
@stavros11 stavros11 deleted the baking branch August 27, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants