Remove results manipulation functions #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1027 +/- ##
==========================================
- Coverage 51.63% 51.37% -0.26%
==========================================
Files 57 56 -1
Lines 2750 2723 -27
==========================================
- Hits 1420 1399 -21
+ Misses 1330 1324 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Sep 6, 2024
|
Please, feel free to merge whenever you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #953. The functions were moved to qibocal in qiboteam/qibocal@27a63c9, but I will leave their potential simplification as part of the qibocal review there. From the qibolab side, we can just remove.
There are some remaining references to the old 0.1 result objects (
IntegratedResults,AveragedIntegratedResults, etc.) in the docs, but I am planning to go through all docs in another PR, so I will take care of them there.