Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator readout module modification #1040

Open
wants to merge 19 commits into
base: emulator-readout
Choose a base branch
from

Conversation

dexonoir
Copy link

@dexonoir dexonoir commented Sep 13, 2024

->Integrated emulator readout module into pulse_simulator, to have readout resonator system, which handles multiple resonators with variable noise models

->Modified demodulation procedure, incorporated dressed frequency, described relationship between bare resonator frequency with dispersive shifted (qubit-state dependent) resonator frequency

  • Equations describing relationship between bare resonator frequency and dispersive shifted resonator frequency are backed up using raw data

  • Homodyne/heterodyne demodulation was used, with the motivation of removing time-dependent component from readout data, to inspect on the phase response of resonator which shall be maximized when resonator is probed just in-between two qubit-state dependent resonance frequencies

  • Provided additional descriptions, improved performance of the readout setup (dispersive effect, SNR effect)

dexonoir and others added 6 commits September 10, 2024 01:03
…ribed relationship between bare resonator frequency with dispersive shifted (qubit-state dependent) resonator frequency, provided examples demonstrating usage of readout module
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a first shallow review

readout_example/readout_example.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Show resolved Hide resolved
src/qibolab/instruments/emulator/readout.py Outdated Show resolved Hide resolved
src/qibolab/execution_parameters.py Outdated Show resolved Hide resolved
readout_example/pulse_simulator_readout.py Outdated Show resolved Hide resolved
readout_example/pulse_simulator_readout.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
… readout, amended code structure for configuration of ReadoutSimulator
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
examples/emulator readout/readout_example.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
src/qibolab/instruments/emulator/pulse_simulator.py Outdated Show resolved Hide resolved
examples/emulator readout/pulse_simulator_readout.py Outdated Show resolved Hide resolved
@jykhoo1987
Copy link
Contributor

@stavros11 @alecandido May I know if this PR is planned to be merged into qibolab 0.1 main? As I understood, no further PRs for 0.1 main will be accepted except for those that are critical/bug fixes. In that regard, the 1q_emulator_upgrades branch is quite ahead of the main branch for emulator-related features. So may I suggest that this PR be pushed first to 1q_emulator_upgrades branch, and then if the plan is to merge to 0.1 main, then we can merge 1q_emulator_upgrades branch to main after that.

@alecandido
Copy link
Member

As you said, 0.1 should be considered not to accept any longer features, but just bug fixes, since the development has been moved to 0.2.

I'd suggest to keep developing this here, since we may need some more structured effort for the upgrade.
So, yes, ideally there should be just one PR with the emulator, that will later be ported to 0.2. This won't be that PR, but regarding the how to reconcile #942 and #985 I have no strong preference (and I personally do not consider a solution urgent - but I may be wrong).

P.S.: to avoid confusion, https://github.com/qiboteam/qibolab/tree/main is 0.2, but there is a https://github.com/qiboteam/qibolab/tree/0.1 branch, so 0.1 with no further specification may well be used to refer to that branch (without any further specifier, as in "0.1 main"). If you want to point to a release, use the full release number, or just 0.1.x to refer to the series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants