Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OPX1000 in QM driver #1045

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Add support for OPX1000 in QM driver #1045

merged 7 commits into from
Oct 21, 2024

Conversation

stavros11
Copy link
Member

There are some errors occuring, particularly when using multiple qubits in parallel, which I have not fully pinpointed yet.

So far I have been able to run some resonator spectroscopy (example http://login.qrccluster.com:9000/5qKIEfDTRHqYx64Y2bOt9g==) and punchout but at maximum 4 qubits simultaneously.

@stavros11 stavros11 added the qm label Sep 16, 2024
@stavros11 stavros11 requested a review from aorgazf September 16, 2024 14:27
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 40 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (30db7ea) to head (721e127).
Report is 8 commits behind head on 0.1.

Files with missing lines Patch % Lines
src/qibolab/instruments/qm/devices.py 45.94% 20 Missing ⚠️
src/qibolab/instruments/qm/config.py 60.00% 8 Missing ⚠️
src/qibolab/instruments/qm/sweepers.py 0.00% 6 Missing ⚠️
src/qibolab/instruments/qm/ports.py 81.48% 5 Missing ⚠️
src/qibolab/instruments/qm/controller.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.1    #1045      +/-   ##
==========================================
- Coverage   70.27%   70.07%   -0.20%     
==========================================
  Files          64       64              
  Lines        6698     6771      +73     
==========================================
+ Hits         4707     4745      +38     
- Misses       1991     2026      +35     
Flag Coverage Δ
unittests 70.07% <58.33%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11
Copy link
Member Author

Apparently qm-qua 1.2.1a2 (or the firmware we are using) has a bug and the offset is not set properly through the config. In 55993b3 I am fixing this by force-setting the offsets through the program API. This allowed us to find the qubits and proceed with the calibration (see qiboteam/qibolab_platforms_qrc#179 (comment)). The assignment fidelities are not as good as before for this chip, however hopefully this is not related to the instrument and driver.

We could wait a couple of days to potentially have some feedback from people using this for calibration, but in the meantime, we can probably proceed with the reviews and eventually merge and port this to 0.2.

@alecandido if we are going to continue merging stuff on 0.1 branch, maybe we also need to sort the Rust API issue in the CI.

@stavros11 stavros11 requested a review from alecandido October 7, 2024 13:35
@stavros11 stavros11 marked this pull request as ready for review October 7, 2024 13:35
@alecandido
Copy link
Member

@alecandido if we are going to continue merging stuff on 0.1 branch, maybe we also need to sort the Rust API issue in the CI.

Yes, removal may also be an option (just to limit the amount of time dedicated).

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes are pretty minimal, so it's not worth to go too much into the details of code optimization for 0.1.
If it worked, that's just fine, and I would postpone further considerations during the analogue 0.2.

I'm assuming you're not introducing any new feature wrt the OPX+, but just make the configs minimally compatible.
E.g. I don't see any option to set output_mode to amplified. But that's fine for the first iteration.

src/qibolab/instruments/qm/controller.py Show resolved Hide resolved
src/qibolab/instruments/qm/config.py Outdated Show resolved Hide resolved
src/qibolab/instruments/qm/ports.py Show resolved Hide resolved
@alecandido
Copy link
Member

Btw, it's interesting that the configs specification is incomplete

image

https://docs.quantum-machines.co/latest/assets/qua_config.html#/paths/~1/get

while you need to fish pieces of the specs from other random places in the docs
image
https://docs.quantum-machines.co/latest/docs/Introduction/config/#controllers

@alecandido alecandido merged commit 32187d4 into 0.1 Oct 21, 2024
22 of 24 checks passed
@alecandido alecandido deleted the opx1000 branch October 21, 2024 16:13
@alecandido alecandido added this to the Qibolab 0.1.10 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants