-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OPX1000 in QM driver #1045
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.1 #1045 +/- ##
==========================================
- Coverage 70.27% 70.07% -0.20%
==========================================
Files 64 64
Lines 6698 6771 +73
==========================================
+ Hits 4707 4745 +38
- Misses 1991 2026 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Apparently qm-qua 1.2.1a2 (or the firmware we are using) has a bug and the offset is not set properly through the We could wait a couple of days to potentially have some feedback from people using this for calibration, but in the meantime, we can probably proceed with the reviews and eventually merge and port this to 0.2. @alecandido if we are going to continue merging stuff on 0.1 branch, maybe we also need to sort the Rust API issue in the CI. |
Yes, removal may also be an option (just to limit the amount of time dedicated). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes are pretty minimal, so it's not worth to go too much into the details of code optimization for 0.1.
If it worked, that's just fine, and I would postpone further considerations during the analogue 0.2.
I'm assuming you're not introducing any new feature wrt the OPX+, but just make the configs minimally compatible.
E.g. I don't see any option to set output_mode
to amplified
. But that's fine for the first iteration.
Btw, it's interesting that the configs specification is incomplete https://docs.quantum-machines.co/latest/assets/qua_config.html#/paths/~1/get while you need to fish pieces of the specs from other random places in the docs |
There are some errors occuring, particularly when using multiple qubits in parallel, which I have not fully pinpointed yet.
So far I have been able to run some resonator spectroscopy (example http://login.qrccluster.com:9000/5qKIEfDTRHqYx64Y2bOt9g==) and punchout but at maximum 4 qubits simultaneously.