Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QM driver fixes #1046

Merged
merged 3 commits into from
Sep 20, 2024
Merged

QM driver fixes #1046

merged 3 commits into from
Sep 20, 2024

Conversation

stavros11
Copy link
Member

Fixing various things, mainly sweeper related, found while testing with #1039. I open a separate PR because I don't think the tests will be merged for 0.2.0, but it would still be good to have the fixes.

I will probably be doing a bit more testing, so I will update this is I find something new.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (dff7479) to head (7ff8ced).
Report is 21 commits behind head on 0.2.

Files with missing lines Patch % Lines
src/qibolab/_core/instruments/qm/controller.py 0.00% 7 Missing ⚠️
...bolab/_core/instruments/qm/program/instructions.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #1046      +/-   ##
==========================================
- Coverage   52.34%   52.22%   -0.12%     
==========================================
  Files          63       63              
  Lines        2820     2826       +6     
==========================================
  Hits         1476     1476              
- Misses       1344     1350       +6     
Flag Coverage Δ
unittests 52.22% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11 stavros11 added this to the Qibolab 0.2.0 milestone Sep 17, 2024
@alecandido
Copy link
Member

Is this actually ready for review?

@stavros11
Copy link
Member Author

stavros11 commented Sep 17, 2024

Is this actually ready for review?

I am not planning to make any changes, but I am still adding some tests in #1039, so if more fixes are needed I will cherry-pick them here. The idea is to test as much as possible before 0.2 is released, but not block the release for the tests. So if you wish we could probably leave this open until we are ready to release, to collect all the fixes found until then.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it on hardware myself, but I'm fine with the changes in here.

@stavros11
Copy link
Member Author

Thanks @alecandido. I will now merge everything to 0.2 and do a final test on hardware.

@stavros11 stavros11 merged commit d5b72ea into 0.2 Sep 20, 2024
27 of 28 checks passed
@stavros11 stavros11 deleted the qm-fixes branch September 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants