-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QM driver fixes #1046
QM driver fixes #1046
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1046 +/- ##
==========================================
- Coverage 52.34% 52.22% -0.12%
==========================================
Files 63 63
Lines 2820 2826 +6
==========================================
Hits 1476 1476
- Misses 1344 1350 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is this actually ready for review? |
I am not planning to make any changes, but I am still adding some tests in #1039, so if more fixes are needed I will cherry-pick them here. The idea is to test as much as possible before 0.2 is released, but not block the release for the tests. So if you wish we could probably leave this open until we are ready to release, to collect all the fixes found until then. |
c059b8b
to
7ff8ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test it on hardware myself, but I'm fine with the changes in here.
Thanks @alecandido. I will now merge everything to |
Fixing various things, mainly sweeper related, found while testing with #1039. I open a separate PR because I don't think the tests will be merged for 0.2.0, but it would still be good to have the fixes.
I will probably be doing a bit more testing, so I will update this is I find something new.