Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties in QibolabBackend #1076

Merged
merged 17 commits into from
Oct 29, 2024
Merged

Add properties in QibolabBackend #1076

merged 17 commits into from
Oct 29, 2024

Conversation

csookim
Copy link
Member

@csookim csookim commented Oct 18, 2024

Qibo needs qubits, connectivity, and natives to create a default transpiler.

https://github.com/qiboteam/qibo/blob/65bdfee7f5d30eb1b18cb31e54a28bac5bfd2e1a/src/qibo/backends/abstract.py#L32-L50

For native_gates, I returned all the native gates that can be executed on at least one case... (couplers are excluded) Please let me know if there is a better approach.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@csookim csookim requested a review from alecandido October 18, 2024 10:32
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.89%. Comparing base (a473d37) to head (a30c552).
Report is 18 commits behind head on 0.1.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.1    #1076      +/-   ##
==========================================
+ Coverage   69.82%   69.89%   +0.07%     
==========================================
  Files          64       64              
  Lines        6859     6876      +17     
==========================================
+ Hits         4789     4806      +17     
  Misses       2070     2070              
Flag Coverage Δ
unittests 69.89% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido changed the base branch from 0.1 to rust-u32 October 18, 2024 11:38
@alecandido

This comment was marked as resolved.

Base automatically changed from rust-u32 to 0.1 October 18, 2024 11:46
@alecandido

This comment was marked as resolved.

alecandido

This comment was marked as resolved.

@alecandido

This comment was marked as resolved.

@csookim

This comment was marked as resolved.

@csookim csookim requested a review from alecandido October 20, 2024 13:08
@alecandido

This comment was marked as resolved.

@alecandido

This comment was marked as resolved.

stavros11

This comment was marked as resolved.

src/qibolab/backends.py Outdated Show resolved Hide resolved
@csookim csookim requested a review from alecandido October 23, 2024 07:21
src/qibolab/backends.py Outdated Show resolved Hide resolved
src/qibolab/backends.py Outdated Show resolved Hide resolved
@csookim csookim requested a review from alecandido October 24, 2024 07:32
src/qibolab/backends.py Outdated Show resolved Hide resolved
@csookim csookim requested a review from alecandido October 25, 2024 06:22
tests/test_backends.py Outdated Show resolved Hide resolved
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, it looks good to me now.

src/qibolab/backends.py Outdated Show resolved Hide resolved
src/qibolab/backends.py Outdated Show resolved Hide resolved
@alecandido

This comment was marked as resolved.

@alecandido alecandido mentioned this pull request Oct 28, 2024
4 tasks
@csookim csookim merged commit 171522a into 0.1 Oct 29, 2024
24 checks passed
@csookim csookim deleted the qibo_global_patch branch October 29, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants