Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for QM Octaves #733

Merged
merged 61 commits into from
Feb 21, 2024
Merged

Support for QM Octaves #733

merged 61 commits into from
Feb 21, 2024

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Jan 4, 2024

Updates the Quantum Machines driver to support Octave devices. Platforms can now be defined with or without Octaves. OPX+ and Octave controllers are exposed as different objects in order to provide the corresponding ports.

qm-qua has been updated to the latest version that supports the current firmware of our cluster.

This has been tested with the instruments but without a qubit connected.

Potentially helpful for review:

  • driver.py was renamed to controller.py (not sure why it appears as new file in the diff),
  • find_sweeper_duration_pulses and Sequence.create were moved from sequence.py to controller.py.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@stavros11 stavros11 added the qm label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (90b5775) 63.88% compared to head (3cf00f2) 65.02%.

Files Patch % Lines
src/qibolab/instruments/qm/controller.py 74.05% 48 Missing ⚠️
src/qibolab/instruments/qm/acquisition.py 69.89% 28 Missing ⚠️
src/qibolab/instruments/qm/config.py 88.33% 7 Missing ⚠️
src/qibolab/instruments/qm/sweepers.py 0.00% 2 Missing ⚠️
src/qibolab/channels.py 80.00% 1 Missing ⚠️
src/qibolab/instruments/qm/devices.py 98.18% 1 Missing ⚠️
src/qibolab/instruments/qm/ports.py 98.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   63.88%   65.02%   +1.14%     
==========================================
  Files          49       50       +1     
  Lines        5793     6025     +232     
==========================================
+ Hits         3701     3918     +217     
- Misses       2092     2107      +15     
Flag Coverage Δ
unittests 65.02% <82.97%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igres26 igres26 self-requested a review February 20, 2024 12:22
Copy link
Contributor

@igres26 igres26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using it successfully to characterize a single qubit 3d chip. There might be some bugs to squash that have not popped up for flux and more complex stuff. But it looks mergeable to me. When Stavros feels it's ready it should be on main so that more people can use it.

@alecandido
Copy link
Member

I agree with @igres26 about merging, we could keep improving in further PRs, but at least we'd have (even preliminary) support for the Octaves.

@stavros11 stavros11 merged commit c34eea4 into main Feb 21, 2024
24 checks passed
@stavros11 stavros11 deleted the octaves branch February 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants