QM driver for 0.2 #874
Closed
QM driver for 0.2 #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #874 +/- ##
==========================================
+ Coverage 48.75% 49.10% +0.35%
==========================================
Files 61 61
Lines 5532 5380 -152
==========================================
- Hits 2697 2642 -55
+ Misses 2835 2738 -97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Apr 20, 2024
Closed
In general, the checks on the serial are quite trivial, just putting the exact same function generating the string that has been used on the other side The only non-trivial part of these tests is the check that the pulse has not been modified after the initialization However, if needed, we'll be able to restore these tests after freezing the dataclasses
To copy, both shallow and deep, just use the dedicated standard library module
QM requires some keys to be strings, because of the way they are later processed. And before they were (by accident, since we were using the serial as an identifier).
for more information, see https://pre-commit.ci
|
Superseded by #933. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates QM driver to work with the current changes in the
0.2branch. I got rid ofQMPulseandQMSequencesince qibolab objects are now simple enough to be used directly. This is not the final version, further changes will be required after the channel refactoring aspulse.qubitandpulse.channelwill be dropped.With the current state it works for the single shot classification routine: http://login.qrccluster.com:9000/3AJ4OvU_QQaTSJdbxk6uwg==
(requires qiboteam/qibolab_platforms_qrc#132 and qiboteam/qibocal#809)
TODO:
QMConfig.