Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect frequencies before processing sweeps #902

Merged
merged 1 commit into from
May 20, 2024
Merged

Collect frequencies before processing sweeps #902

merged 1 commit into from
May 20, 2024

Conversation

hay-k
Copy link
Contributor

@hay-k hay-k commented May 15, 2024

Processed sweeps uses frequency from characterization section. This leads to inconsistency when user updates the frequency of native pulse, but does not update the characterization section (e.g. readout_frequency). This change fixes this inconsistency.

All of this is being removed for 0.2 release (#885). This fix is needed for short term, before the realease.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@hay-k hay-k requested review from Jacfomg, alecandido and stavros11 May 15, 2024 09:31
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.64%. Comparing base (b93ee1b) to head (5f5f54a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files          55       55           
  Lines        5954     5954           
=======================================
  Hits         3968     3968           
  Misses       1986     1986           
Flag Coverage Δ
unittests 66.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hay-k hay-k merged commit a964ab2 into main May 20, 2024
33 checks passed
@scarrazza scarrazza deleted the fix-frequency branch June 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants