Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QM for new qubits/channels #172

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Update QM for new qubits/channels #172

merged 7 commits into from
Sep 3, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Aug 26, 2024 •
edited
Loading

stavros11
stavros11 reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'd just keep on hold until we confirm that it works well on hardware using the corresponding qibolab branches.

qw11qD/platform.py Outdated Show resolved Hide resolved
qw11qD/platform.py Outdated Show resolved Hide resolved
qw11qD/platform.py Outdated Show resolved Hide resolved
@alecandido
Copy link
Member Author

Looks good to me, I'd just keep on hold until we confirm that it works well on hardware using the corresponding qibolab branches.

Yes, definitely.

I also wanted to test with Qibocal (I have my own branch, based on yours, but for a weird reason related to submodules is now living in a fork https://github.com/alecandido/qibocal/tree/qibolab0.2-qubits - I will bring it back as soon as I'm ready).

@alecandido alecandido force-pushed the 0.2-qw11qD-qubits branch 2 times, most recently from 3f71bfd to 99d083f Compare August 28, 2024 14:27
@alecandido alecandido force-pushed the 0.2-qw11qD-qubits branch 2 times, most recently from 7a38b50 to 7374483 Compare August 28, 2024 15:42
@alecandido alecandido changed the base branch from 0.2-qw11qD to 0.2-qw11qD-qmconfigs August 28, 2024 15:43
Base automatically changed from 0.2-qw11qD-qmconfigs to 0.2-qw11qD August 28, 2024 22:29
An error occurred while trying to automatically change base from 0.2-qw11qD-qmconfigs to 0.2-qw11qD August 28, 2024 22:29
@alecandido alecandido mentioned this pull request Aug 30, 2024
Merged
7 tasks
@alecandido alecandido marked this pull request as ready for review September 2, 2024 10:01
@alecandido alecandido requested a review from stavros11 September 2, 2024 10:01
@stavros11 stavros11 merged commit 367a262 into 0.2-qw11qD Sep 3, 2024
1 of 3 checks passed
@stavros11 stavros11 deleted the 0.2-qw11qD-qubits branch September 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavros11 stavros11 stavros11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecandido @stavros11