Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added activations in tests #55

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Nov 21, 2024

Adds activations similar to the one used in the notebook #49.
Various fixes to the tests are also introduced.
Makes BinaryEncoding a layer of RX in practice and gets rid of the 1/0 check and branching.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (3e52004) to head (04632be).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #55       +/-   ##
===========================================
+ Coverage   61.06%   78.85%   +17.78%     
===========================================
  Files          11       11               
  Lines         488      487        -1     
===========================================
+ Hits          298      384       +86     
+ Misses        190      103       -87     
Flag Coverage Δ
unittests 78.85% <100.00%> (+17.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qiboml/models/encoding.py 95.23% <100.00%> (-0.12%) ⬇️
src/qiboml/models/pytorch.py 98.59% <ø> (+57.74%) ⬆️

... and 3 files with indirect coverage changes

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review November 24, 2024 08:43
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi merged commit 1c2ba25 into main Dec 6, 2024
26 checks passed
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi deleted the activation_in_tests branch December 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant