-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LANG: python 3.10 update (amplicon) #367
Conversation
Okay so current issue here is from q2-fragment-insertion's pin of |
Okay so it looks like the latest version of sepp resolved this issue (less than two weeks ago!) and builds are now up on bioconda. Paired PR in fragment-insertion that removes this pin - we'll see if this works! |
Another paired PR in alignment - this punts the mafft pin back to alignment's recipe, using the min pin previously present |
Wow, it looks like it practically worked! Now that you have a solve, I would recommend putting mafft back into the seed env with the new pin (whatever that ended up being), and also maybe we should do the same for dendropy? That way we can control all of these in one place. (I realize that you needed the >= operator to try and solve for mafft, which wouldn't have worked in the seed env... probably?) |
PR to address test failures in vsearch (very minor): qiime2/q2-vsearch#99 I'll try adding mafft as a min pin in the seed env @ebolyen - conda's docs do state that pin ranges are supported, and that might be better for this situation. I'm debating between pinning sepp and dendropy, since sepp is the root offender. Now that I've written that out, I think I'm leaning towards a min pin for sepp - that way we're just ensuring we have at least the build that's fixed that old dendropy dependency. EDIT: so even though conda supports pin ranges, it doesn't seem to be easily compatible with the jinja templating for package versions (within each individual package) - so i've just set the pins for mafft and sepp, and we'll just fuss with them if/when they stop working. |
We've got a working build! 🥳 |
local install of all external dependencies was successful, so now it's time to see what breaks!