Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classifier text and replace with external link #578

Merged
merged 3 commits into from
May 20, 2024

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented May 16, 2024

Replace the classifier stuff in the docs with a link to https://resources.qiime2.org

@Oddant1
Copy link
Member Author

Oddant1 commented May 16, 2024

Do we want that first note there or not? The way the code is flowed suggests it's supposed to be associated with the Marker gene reference databases section, but it looks awkward, and there is already another copy of that note at the bottom of that section.

image

@Oddant1
Copy link
Member Author

Oddant1 commented May 16, 2024

Looks like this without the note, I think without is much better I only ask because like I said the way the code is written looks like the intent is for the note to be associated with the section beneath it
image

@gregcaporaso
Copy link
Member

gregcaporaso commented May 17, 2024

@Oddant1, we don't need that note, so let's go with your second example above. I suspect that note was just misplaced with respect to the anchor that follows it right now.

This is ready for merge once you remove that note. Thank you!

@Oddant1 Oddant1 merged commit 4f078d6 into qiime2:master May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants