Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMP: adds underscore prefix to helper method inside filter seqs tests #297

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

hagenjp
Copy link
Contributor

@hagenjp hagenjp commented Dec 12, 2023

Closes #296

@hagenjp
Copy link
Contributor Author

hagenjp commented Dec 12, 2023

@lizgehret this is ready for your review when you have time :)

@hagenjp hagenjp self-assigned this Dec 12, 2023
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @hagenjp!

@lizgehret lizgehret merged commit 1a46f7c into qiime2:dev Dec 12, 2023
5 checks passed
@lizgehret lizgehret changed the title IMP: Minor changes to helper function inside filter seqs test IMP: adds underscore prefix to helper method inside filter seqs tests Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

IMP: helper method in filter_seqs should have an underscore prefix
2 participants