-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: group-timepoints/engraftment pipeline take to_baseline param #71
Conversation
…o take to_baseline param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all generally lgtm @cherman2! all of the comments below are just tiny formatting adjustments (from single quotes to ``) - this will just format those params nicely in the command line.
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
Thanks @lizgehret. I definitely agree that `` is more readable. I'll remember to do that next time i'm adding error messages! |
These tests failures are happening when my typeMap for group-column = false. I need to figure out what the other type maps are doing to make this work. I am kinda getting confused between my PRs. I feel like this PR shouldn't have group-column (that should come from #78) |
Oh weird, I don't see those test failures here, only in #78 (at least in these latest CI runs). I'll reply on that PR re: those particular test failures (the ones in this PR aren't interesting). |
You are right they are only on #78. I need to do a better job of naming concurrence prs . I think I am literally confusing these prs because they both start with REF: group-timepoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all very small things @cherman2 - once these are updated, i'll pull this down locally to make sure all tests pass and then this should be gtm!
Co-authored-by: Liz Gehret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay @cherman2, this all lgtm - when I replace GroupDist instances (still present on this branch) with Dist1D and run tests locally, they all pass. Would you prefer I wait until #78 is merged to merge this one? Tests won't pass until that PR is merged b/c of the type updates - but realistically it'll be fine either way (since we're going to get that one merged soon too).
I guess I think just merge it because my CI isn't set-up yet and we will be merging #78 soon. but I definitely defer to your opinion! |
This PR refactors group-timepoints action and engraftment pipeline allow "to_baseline" parameter.
This PR changed
TODO: