Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: minor fixes from working with Jeff #91

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

cherman2
Copy link
Contributor

@cherman2 cherman2 commented Aug 19, 2024

This PR Fixes 3 issues that were identified while working with Jeff:

  • Rename drop-incomplete-timepoint to drop-incomplete-timepoints
  • move when I was filtering drop-incomplete-timepoints so I don't get a weird error
  • hand None to optional stats so they don't error

@cherman2 cherman2 changed the title REF: minor fixes for convience and clarity REF: minor fixes from working with Jeff Aug 20, 2024
@cherman2 cherman2 removed their assignment Aug 22, 2024
@lizgehret lizgehret self-assigned this Aug 22, 2024
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lgtm! 🚀

@lizgehret lizgehret merged commit 8d09ffa into qiime2:dev Aug 26, 2024
4 checks passed
@lizgehret lizgehret assigned cherman2 and unassigned lizgehret Aug 26, 2024
@cherman2 cherman2 removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants