-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: q2-fmt ci #92
REF: q2-fmt ci #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this lgtm @cherman2! one small inline change to your README for your environment name and this should be ready for merge.
the only thing i noticed (that i'm assuming you did intentionally) is that your env files for 2024.10 and dev are targeting identical channels (2024.10/amplicon/passed) - i don't think it matters, but you could probably consolidate to just the dev env. I don't have strong feelings either way, so you can take that suggestion or leave it as-is!
Co-authored-by: Liz Gehret <[email protected]>
Thanks @lizgehret! Will you do the mergonors (merge honors)? |
Roger that, makes sense to me @cherman2! lgtm!! 🚀 |
Following dwq2 How-Tos on how to implement CI and GHA for weekly testing