Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: q2-fmt ci #92

Merged
merged 13 commits into from
Sep 6, 2024
Merged

REF: q2-fmt ci #92

merged 13 commits into from
Sep 6, 2024

Conversation

cherman2
Copy link
Contributor

@cherman2 cherman2 commented Sep 5, 2024

Following dwq2 How-Tos on how to implement CI and GHA for weekly testing

@cherman2 cherman2 changed the title Q2 fmt ci REF: q2-fmt ci Sep 5, 2024
@cherman2 cherman2 self-assigned this Sep 5, 2024
@colinvwood colinvwood assigned lizgehret and unassigned cherman2 Sep 5, 2024
@cherman2 cherman2 added this to the Manuscript Prep milestone Sep 5, 2024
Copy link
Member

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this lgtm @cherman2! one small inline change to your README for your environment name and this should be ready for merge.

the only thing i noticed (that i'm assuming you did intentionally) is that your env files for 2024.10 and dev are targeting identical channels (2024.10/amplicon/passed) - i don't think it matters, but you could probably consolidate to just the dev env. I don't have strong feelings either way, so you can take that suggestion or leave it as-is!

README.md Outdated Show resolved Hide resolved
@lizgehret lizgehret assigned cherman2 and unassigned lizgehret Sep 6, 2024
Co-authored-by: Liz Gehret <[email protected]>
@cherman2
Copy link
Contributor Author

cherman2 commented Sep 6, 2024

Thanks @lizgehret!
You are right that currently those are duplicates. I guess I kinda thought of this as creating a system. Like once .10 is release I will change the env file to use 2024.10/released and I will bump my dev on to use 2025.4/passed. Then I will start making the env files per release like suggested. I would have done a 2024.5 env but q2-fmt wont build there becuase of stats.

Will you do the mergonors (merge honors)?

@cherman2 cherman2 assigned lizgehret and unassigned cherman2 Sep 6, 2024
@lizgehret
Copy link
Member

Roger that, makes sense to me @cherman2!

lgtm!! 🚀

@lizgehret lizgehret merged commit 5d50b7d into qiime2:dev Sep 6, 2024
3 checks passed
@lizgehret lizgehret deleted the q2-fmt-ci branch September 6, 2024 23:51
@lizgehret lizgehret removed their assignment Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants