Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reword README #1388

Merged
merged 1 commit into from
Oct 16, 2023
Merged

docs: reword README #1388

merged 1 commit into from
Oct 16, 2023

Conversation

mochaaP
Copy link

@mochaaP mochaaP commented Sep 23, 2023

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature updates.
  • This PR introduces a new function/API for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update the changelog.
  • The changelog will be updated after some proper review.
  • The changelog has been updated in my PR.

Target branch?

  • The target branch is the dev branch.

One last thing


Fix format, typos, grammar issues in README.

@xwings
Copy link
Member

xwings commented Sep 25, 2023

looks better :)

my two cents,

  1. it would be amazing if you can work on docs.qiling.io
  2. as for the readme.md remove the very last line

@xwings
Copy link
Member

xwings commented Sep 26, 2023

Sorry, What i mean is

remove this line

and keep this

@mochaaP
Copy link
Author

mochaaP commented Sep 26, 2023

Got it. I'm also working on https://github.com/qilingframework/rtfd.io now, there are some big changes ahead, so if you want to review it first just ping me up in the Telegram group 😉

also this: qiling2_logo_big-fs8

@xwings xwings merged commit a3c7818 into qilingframework:dev Oct 16, 2023
5 checks passed
@mochaaP mochaaP deleted the reword-readme branch October 16, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants